Re: [scc-dev] [PATCH 1/3] make/posix: fix feature test macros

From: Roberto E. Vargas Caballero <k0ga_at_shike2.net>
Date: Fri, 28 Feb 2025 09:06:16 +0100

Quoth lhr_at_disroot.org:
> > Can you be more explicit about what macros? I don't think we use
> > anything that is XSI [...]
>
> S_IFMT and S_IFDIR are used in scc-make/posix.c; glibc requires _XOPEN_SOURCE
> for all S_IF* macros, but not the S_IS* macros, although the GNU/Linux stat(2)
> manpage doesn't document this. POSIX does say[1] the S_IF* macros are part of
> the XSI (except for S_IFMT), while the S_IS* macros are core POSIX, so maybe
> for portability it should be:

Yeah, good point. We should migrate to use the S_* macros, and then
define the _POSIX_C_SOURCE with the same value than in src/cmd/scc-cc/cc.c.
If you agree, I will rework the patches as I commented before and put
you as author (I will send them to the mailing list before applying).
Is it ok?

Regards,

--
To unsubscribe send a mail to scc-dev+unsubscribe_at_simple-cc.org

Received on Fri 28 Feb 2025 - 09:06:16 CET