Quoth remph <lhr_at_disroot.org>:
> --- a/tests/libc/execute/0035-setlocale.c
> +++ b/tests/libc/execute/0035-setlocale.c
> _at_@ -1,6 +1,7 @@
> #include <assert.h>
> #include <locale.h>
> #include <stdio.h>
> +#include <string.h>
>
Yeah, good catch.
> diff --git a/tests/libc/execute/0036-localeconv.c b/tests/libc/execute/0036-localeconv.c
> index cdb069db..05a2cbf4 100644
> --- a/tests/libc/execute/0036-localeconv.c
> +++ b/tests/libc/execute/0036-localeconv.c
> _at_@ -2,6 +2,7 @@
> #include <limits.h>
> #include <locale.h>
> #include <stdio.h>
> +#include <string.h>
>
> /*
> output:
Yeah, good catch.
> diff --git a/tests/libc/execute/0037-malloc.c b/tests/libc/execute/0037-malloc.c
> index e22d64ba..7da82b0a 100644
> --- a/tests/libc/execute/0037-malloc.c
> +++ b/tests/libc/execute/0037-malloc.c
> _at_@ -1,9 +1,11 @@
> #include <assert.h>
> #include <stdlib.h>
> +#include <stdio.h>
>
> /*
> output:
> -
> +testing
> +done
> end:
> */
>
I think the issue in this tests is a bit more complex:
for (i = 0; i < 100; i++)
assert(p[i] == NULL);
/* TODO: Add a verifier here */
We need a validator of the heap. That only can be achived
adding an internal function in the libc with knowledge
about the heap structure. In fact, we had a realloc()
test around with the same problem. I prefer to keep the
TODO while we don't write the verifier.
For that reason, I think I am going to apply the diff but
without the last chunk (or maybe only with the required
include, but keeping the expected error).
Regards,
--
To unsubscribe send a mail to scc-dev+unsubscribe_at_simple-cc.org
Received on Tue 25 Feb 2025 - 16:10:43 CET